[accname] Explicitly state UAs must ignore “aria-label” for slots #2385
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change updates the AriaLabel substep of the “Computation steps” section of the “Accessible Name and Description Computation” spec to explicitly state that the step must not be performed if the node being visited is a slot element.
✅ Deploy Preview for wai-aria ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
keithamus
approved these changes
Jan 9, 2025
MelSumner
approved these changes
Jan 23, 2025
cookiecrook
approved these changes
Jan 23, 2025
accdc
approved these changes
Jan 23, 2025
|
I added a link above to the existing WPT tests for accname on slots... See tests 3 and 4. If more tests are needed, please file a new issue on interop-accessibility. Thanks Mike! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the AriaLabel substep of the “Computation steps” section of the accname spec to explicitly state that the step must not be performed if the node being visited is a
slotelement.See the discussion at w3c/accname#173. It seems a requirement to ignore the
aria-labelattribute in this case — or to ignore any ARIA attributes present onslotelements — may follow from normative requirements stated in some other spec.Nevertheless, a specific requirement should be stated at point of use in the text for this step in accname spec itself.
Test, Documentation and Implementation tracking
Once this PR has been reviewed and has consensus from the working group, tests should be written and issues should be opened on browsers. Add N/A and check when not applicable.