T6718: use the vyconf daemon for validation of set commands #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expose legacy set/delete functions in a form suitable for external calls.
Legacy set/delete methods write errors to stdout; capture for redirection in return value.
Separate the application of validators from the cstore update.
The ctypes binding makes a copy of the string return value; the originating C memory allocation needs to be explicitly managed.
|
👍 |
10 tasks
10 tasks
jestabro
force-pushed
the
vyconf-minimal
branch
from
f537a26 to
a428d47
Compare
dmbaturin
approved these changes
Nov 19, 2024
| return ""; | ||
| } | ||
|
|
||
| char buffer[1024]; |
There was a problem hiding this comment.
This value can be arbitrary, but I wonder if a larger size can provide slightly better performance.
c-po
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
This is a companion PR for
vyos/vyconf#11
It exposes and separates the legacy validate/set function for use by the vyconf vyos1x-adapter.
Types of changes
Related Task(s)
Related PR(s)
Component(s) name
Proposed changes
How to test
Smoketest result
Checklist: