-
Notifications
You must be signed in to change notification settings - Fork 686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PPO + Transformer-XL #459
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
pre-commitpre-commit fails because of two "obsolet" imports: memory_gym and PoMEnv. Without those imports, the environments are not registered inside gymnasium. enjoy.pyI added a script to load a trained model and then watch an episode. ProofofMemory-v0 and MiniGrid-MemoryS9-v0These environments require memory and converge pretty fast. That's why I included those initially. MemoryGym environments take in more time and resources (especially GPU memory due to the cached hidden states of Transformer-XL). TODOI still have to run the benchmarks and write documentation. Besides that, the single file implementation is basically done. I tried to stay close to ppo_atari_lstm.py |
…initial to final value.
…nused imports, however these imports are necessary for the used environments to be registered
…yperparameters for succesfull MMG training
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is very well-made PR. Thanks @MarcoMeter! Could you fix the test by just removing the macos-latest
from the os: [ubuntu-22.04, macos-latest, windows-latest]
in .github/workflows/tests.yaml
? We can merge after that :)
What are you referring to? This is how I created the report:
Thanks for your feedback =) |
Oh I meant the error bar (shadow region) is very large for some reason, but it’s fine. I have added you to the list of contributors. Feel free to merge after CI passes. |
It seems that other reports have this as well, like: |
…dded proper rendering to ProofofMemory-v0, updated docs for training and enjoying MiniGrid and ProofofMemory-v0
I did some refinements:
My last step before merging is to make sure that poetry and the dependencies blend well. |
Done. |
Description
Implementation of PPO with Transformer-XL as episodic memory.
Based on this repo and paper.
Types of changes
Checklist:
pre-commit run --all-files
passes (required).mkdocs serve
.If you need to run benchmark experiments for a performance-impacting changes:
--capture_video
.python -m openrlbenchmark.rlops
.python -m openrlbenchmark.rlops
utility to the documentation.python -m openrlbenchmark.rlops ....your_args... --report
, to the documentation.