-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows: add --verbose
option for ldrmodules
plugin.
#968
base: develop
Are you sure you want to change the base?
Windows: add --verbose
option for ldrmodules
plugin.
#968
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very much, very swift fix to issue #968. I have a few concerns though, we try not to put separate data items into a single field, and where possible (it's not always feasible) we try to not to change the layout of the table based on an input option. I'm happy to do that here if it's necessary, but it might just be worth always outputting the full data all the time, depending on how ugly it gets? Lemme know what you think and we can come up with the best way forward... 5:)
try: | ||
if load_mod: | ||
load = "{0} : {1}".format( | ||
load_mod.FullDllName.get_string(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do these two values differ, or is the BaseDllName
part of the FullDllName
? Either way we try hard to avoid textually combining data into a single column, because it means that a program using volatility as a library has to do work to split the data back up into its components. As such, I'd either change the default column entry to the full one (and forget the flag) or if both bits of information are important, then I'd output a second column.
It's slightly more effort, but it will make it much easier for other code to process the results, and humans will still be able to read it. Since we have version numbers we can change the default output of a plugin without too much issue (and people can check the version number if they depend on specific columns).
) | ||
), | ||
) | ||
if not self.config.get("verbose", True): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing column outputs is doable, but it potentially makes it tricky for things that use the output of plugins automatically (nothing does that I know of yet, and they could read the data from the TreeGrid
they get back, but...). If the extra data isn't too messy, then I'd just output it all, all the time. If it is, then we can go with the optional columns, but again, we're trying to return things as if we're in a database, so separation of things that are separate and as little duplication as possible... 5:)
Thank you for your review @ikelos. |
Description
Hello, everyone in the community! :)
This PR comes from this issue (#967).
It will be meaningful to re-implement the original features of volatility.
Examples