Plugins: Initial prototype crashdump writer #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikelos
changed the title
Closed
ikelos
commented
May 3, 2022
| dump_header_name = '_DUMP_HEADER' | ||
| valid_dump_suffix = [ord('M'), ord('P')] | ||
|
|
||
| config_path = 'whatever' |
There was a problem hiding this comment.
Bad past @ikelos , very, very bad. This sets a really bad example, and this needs changing before this gets committed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a placeholder but has most of the code for creating a valid crashdump file. The things it's currently missing are:
KD_DEBUGGER_DATAstructure and also anything to do with the KPCR (setting dummy values, decoding it, etc).@iMHLv2 This isn't done yet, but I figure this gives us visibility of the branch. I know that writing seems less simple than in volatility 2 (
.write()rather than=) but it turns out there's time want to change the programmatic structure without writing it back to the file (for example, some tricks we play generating structures in pdbconv). It's also not clear whether assignment should fail if the file is unwritable for some reason (whereaswritefailed is to be expected). I think that's ok, but if you can think of something simpler that still allows us to differentiate between in-memory assignment and physical rewriting then I'm all for it... 5:)