Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Actions: Add new workflow for generating windows EXEs with pyinstaller #1549

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Actions: Add new workflow for generating windows EXEs with pyinstaller #1549

wants to merge 1 commit into from
+50 −0

Conversation

cgoodwine
Copy link

  • This PR provides an alternative to Actions: Add section for building windows exe #1111 for generating pyinstaller executables for Windows via GithHub actions. The main difference is that this version uses a new GitHub workflow file for clearer separation.
  • If this looks good, I can submit a separate PR that adds some basic testing to the generated pyinstallers

@cgoodwine
Copy link
Author

@npetroni and @ikelos could you please give feedback on this pull request when you have a chance? Thanks!

@npetroni npetroni requested review from ikelos and npetroni January 14, 2025 21:02
@npetroni
Copy link

This looks cleaner to me, thanks @cgoodwine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikelos ikelos Awaiting requested review from ikelos

@npetroni npetroni Awaiting requested review from npetroni

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cgoodwine @npetroni