Prevent Linux's list_tasks from yielding completely broken process in… #1518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikelos
approved these changes
Jan 4, 2025
| # this stops the processing | ||
| if not task.has_valid_name_and_pid(): | ||
| vollog.debug( | ||
| f"Found an smeared/invalid task at offset {task.vol.offset:#x}" |
There was a problem hiding this comment.
I'd drop the smeared/ from this because otherwise the an sticks out.
|
|
||
| # ensure the pid within the bounds of a signed int | ||
| # and that we have something of a name | ||
| return (0 < pid < 2147483647) and len(name) > 0 |
There was a problem hiding this comment.
If the type of pid is signed int, can it ever be outside these bounds?
There was a problem hiding this comment.
Aren't we opening the door to task hiding in memory forensics with this? Writing \x00 to the comm field could even be done from user space with just a syscall. Also, we definitely shouldn't use break there. Doing so not only allows a single task to hide but also exposes all subsequent tasks to the same risk.
There was a problem hiding this comment.
Minor but technically speaking it has to be (0 < pid <= 2147483647)
>>> struct.unpack('i', b"\xff\xff\xff\x7f")
(2147483647,)
>>> struct.unpack('i', b"\xff\xff\xff\x80")
(-2130706433,)
gcmoreira
reviewed
Jan 4, 2025
| vollog.debug( | ||
| f"Found an smeared/invalid task at offset {task.vol.offset:#x}" | ||
| ) | ||
| break |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…stances