Linux: Fix task parent pid in several plugins #1412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It also adds a method to get the correct one in a unified way from the task object extension
ikelos
reviewed
Dec 17, 2024
There was a problem hiding this comment.
Thanks for fixing all the consumer plugins and bumping their versions. I think there's still some version work to be done, and I'm a little concerned about the return pid if there's an error (rather than just throwing an exception). Really don't like papering over problems and particularly when the caller of the function can't differentiate the error condition from an actual valid response.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linux plugins are using the wrong value for the parent process identifier (PPID).
Using
task.parentcan result in inaccurate results, especially in cases involving ptraced processes (refer to PR #1288 for more details).This PR introduces a new method in the task object extension that mimics the Linux kernel's getppid syscall, ensuring correct and consistent retrieval of the parent PID.