Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: Update get_commit_charge extension to handle Core.CommitCharge case #1407

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

eve-mem
Copy link
Contributor

@eve-mem eve-mem commented Dec 16, 2024

Hello 👋

This will hopefully fix #1400 - however I do not have a sample to test with. Please wait until @KQBTD is able to confirm.

This changes the windows extension for get_commit_charge to handle the case where the results we're after are stored in Core.CommitCharge as pointed out by @atcuno.

Thanks!
🦊

@eve-mem eve-mem marked this pull request as draft December 16, 2024 17:58
@eve-mem eve-mem mentioned this pull request Dec 16, 2024
@eve-mem
Copy link
Contributor Author

eve-mem commented Dec 16, 2024

Marked as draft while waiting for @KQBTD

@ikelos ikelos self-requested a review December 16, 2024 23:56
Copy link
Member

@ikelos ikelos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me.

@eve-mem
Copy link
Contributor Author

eve-mem commented Dec 17, 2024

Hopefully it works as intended.... :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Malfind broken
3 participants