Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linux: Address limitations in determining KASLR shifts by introducing VMCoreInfo support #1332
base: develop
Are you sure you want to change the base?
Linux: Address limitations in determining KASLR shifts by introducing VMCoreInfo support #1332
Changes from 18 commits
512c1ab
b4b7834
6610779
5ab9756
00b528a
41a9347
4c0ddca
4a88a74
f2a2f8a
d80ef55
13729ac
96f5fda
9f6d194
41d2e92
bbd2f9b
03aba8d
d14c777
d56f3a5
7858af3
7ed8b99
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check failure on line 5 in volatility3/framework/automagic/linux.py
GitHub Actions / lint
Ruff (F401)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, this will go wrong for virtualized hosts. We're still a little way off supporting them yet, but definitely one not to forget about...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had you wanted to pass the vmcore through the metadata? If so, here's where you'd do it, I guess? Don't remember if we mind metadata being complex types...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Scratch that, I just read back through the old comments and know why that won't work.. We probably should pull the metadata across from the constructed layer after stacking (although loading it from a config won't pull it across, so it might still require a mechanism to repopulate somehow)...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given we use this twice, should it not be a property or something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think this is the same as
f"{value:#x}"
?