-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linux: Update sockstat to render process names #1271
Linux: Update sockstat to render process names #1271
Conversation
@ikelos this is a high priority change for the October release. Also, please make sure the version bump is correct here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty straightforward change, but altering the return value requires a MAJOR version bump (because it's not a simple additive change to the API).
Currently, process names are not displayed for sockets in the sockstat plugin, making analysis more painful than it needs to be. This updates the `list_sockets` classmethod and the `generator` method to return the process name in addition to the PID. Because this is changing the public interface, this commit includes a major version bump for `linux.sockstat.Sockstat`.
4b8b5de
to
7f37135
Compare
I thought I had already bumped the version but apparently not, it's done now. There are no consumers of this plugin that require updating. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now, thanks
…ityfoundation#1271 for the list_sockets class_method
…tends the interface of the list_sockets() class method
Currently, process names are not displayed for sockets in the sockstat plugin, making analysis more painful than it needs to be. This updates the
list_sockets
classmethod and the_generator
method to return the process name in addition to the PID.Because this is changing the public interface, this commit includes a major version bump for
linux.sockstat.Sockstat
.