Fix changes introduced to volatility3.framework.constants in PRs #838 #1268
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to use the changes in #1247 I found that the following works
However, the following fails:
Debugging why the import doesn't fail but instead gets a
None
, which is really weird, I found this happens because the changes introduced to support deprecated constants in PRs #838 in this line.Completely removing the
__getattr__()
function works as expected.The changes in this PR keep the
__getattr__()
function while still allowing the use of sub-modules ofvolatility3.framework.constants
.