krita: fix scripts not working with python3.13 #53965
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why was CI skipped? |
|
Because building Krita does take a long time. (Same as Thunderbird I would think) |
|
Don't try to guage build times on CI and preempt testing, just let it build. Also, stop skipping CI on Thunderbird. |
sgn
reviewed
Jan 15, 2025
| app = QApplication(sys.argv) | ||
| install() | ||
| - print("Triggering error 1") | ||
| + print("Triggering error 1")f |
There was a problem hiding this comment.
This patch likely created twice, and apply directly on each other, please change.
There was a problem hiding this comment.
This is a major reason we don't want submitters skipping CI. Remove the [ci skip] from your comment and let our tests do their jobs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing the changes
Local build testing
[ci skip]