Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: iamb-0.0.10 #49652

Merged
merged 1 commit into from
Jan 14, 2025
Merged

New package: iamb-0.0.10 #49652

merged 1 commit into from
Jan 14, 2025

Conversation

Bnyro
Copy link
Contributor

@Bnyro Bnyro commented Apr 1, 2024

Testing the changes

  • I tested the changes in this PR: YES

New package

Local build testing

  • I built this PR locally for my native architecture, x86_64-glibc

closes #49586

@classabbyamp classabbyamp added the new-package This PR adds a new package label Apr 1, 2024
@AnInternetTroll
Copy link
Contributor

Tested on x86_64-glibc, joined a room and sent a message. Works as expected!

@AnInternetTroll
Copy link
Contributor

Super duper nitpick, but the manpage is technically wrong on void
https://github.com/ulyssa/iamb/blob/e5b284ed19cb99f79a0cbaca9e2339b9171e6d6d/docs/iamb.5#L541C1-L543C43

.Sy iamb
will load if the TOML one is not found.
.It Pa /usr/share/iamb/config.example.toml
A sample configuration file with examples of how to set different values.
.El

Should actually be /usr/share/examples/iamb/config.example.toml, with an added examples/

@AnInternetTroll
Copy link
Contributor

Tested it again with the lib changes and it still works

@Bnyro
Copy link
Contributor Author

Bnyro commented Apr 7, 2024

I guess we should report the test failure om i686 upstream?

@AnInternetTroll
Copy link
Contributor

I guess we should report the test failure om i686 upstream?

I've let them know on matrix that the one test is failing on 32bit (I assume it would fail on armv* as well if the CI would run those tests)

--

About my earlier comment on the manpage, what I meant to say is that maybe the manpage should be vsed'd to change that one line. Something like this for example

vsed -i docs/iamb.5 -e 's#/usr/share/iamb/config.example.toml#/usr/share/examples/iamb/config.example.toml#'

You should still vsconf the file though, that part was correct

@Bnyro Bnyro force-pushed the iamb branch 2 times, most recently from 5b298fb to f28c87c Compare June 1, 2024 21:52
@Bnyro Bnyro mentioned this pull request Aug 28, 2024
@Bnyro Bnyro changed the title New package: iamb-0.0.9 New package: iamb-0.0.10 Aug 28, 2024
Copy link

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label Nov 27, 2024
@Bnyro
Copy link
Contributor Author

Bnyro commented Nov 27, 2024

bump

@github-actions github-actions bot removed the Stale label Nov 28, 2024
@Anachron
Copy link
Contributor

Anachron commented Jan 9, 2025

I think this can be merged.
The client works as expected, is in current version and has been tested on multiple arch/libc-implementations.
My testing with x86_64-glibc was successful as well. I love it!

@tranzystorekk tranzystorekk merged commit 13f1bec into void-linux:master Jan 14, 2025
8 checks passed
@Bnyro Bnyro deleted the iamb branch January 14, 2025 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-package This PR adds a new package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package request: iamb
5 participants