[Frontend][Core] Override HF config.json via CLI

[KrishnaM251]

FIX #1542
FIX #2547
FIX #5205

PR Title and Classification

[Frontend] [Core]

Notes

• While I believe the implementation is almost complete, the test I wrote only checks if the new Optional[dict] parameter hf_kwargs is succesfully set in ModelConfig.
• I would like to write a test that detects a change in the LLMEngine output when kf_kwargs is added as a EngineArgs parameter.
• But I have two questions:
  • How can I write another test that runs hf_kwargs through an OpenAI compatible server? I wanted to repurpose a test in test_openai_server.py, however the EngineArgs params are set before all tests are run.
  • What are some test values that I can set in hf_kwargs which will generate output detectable in a function like: completion = client.completions.create(...) (motivating example). If this is not the best approach for testing, then any recommendations?

[simon-mo]

@DarkLight1337 can you help answer the question since you recently touched the testing harness.

Additionally, there might be other places we want override including tokenizer or generation config. Addressing those will be nice to have.

[DarkLight1337]

Thanks for picking this up! To answer your questions:

• How can I write another test that runs hf_kwargs through an OpenAI compatible server? I wanted to repurpose a test in test_openai_server.py, however the EngineArgs params are set before all tests are run.

You should launch a new instance of the server. Each RemoteOpenAIServer instance creates a new subprocess that invokes the OpenAI entrypoint through the command line, so you can't change the hf_config after instantiating it.

You can add pytest fixtures to use a different server for your tests.

• What are some test values that I can set in hf_kwargs which will generate output detectable in a function like: completion = client.completions.create(...) (motivating example). If this is not the best approach for testing, then any recommendations?

Maybe you can set the attention implementation to eager, which from my understanding would cause some numerical inaccuracies compared to the default one. Actually, this may not work since we are running the vLLM model rather than the HF model.

Perhaps you can ask the author of the original issue what they want to accomplish using this feature that cannot otherwise be done via vLLM args. (If we don't have any situation that results in different vLLM output, what is the point of enabling this?)

[KrishnaM251]

@DarkLight1337 I appreciate the response. I will do as you suggested.

[vpellegrain]

Hi @KrishnaM251,

Any news on this?

I have a specific use case in which I'd like to deploy a Phi3.5-vision model on a vLLM openai server entrypoint ; but i'd like to specify the argument num_crops=16 (which is by default 4 in the preprocessor config file).

[DarkLight1337]

Hi @KrishnaM251,

Any news on this?

I have a specific use case in which I'd like to deploy a Phi3.5-vision model on a vLLM openai server entrypoint ; but i'd like to specify the argument num_crops=16 (which is by default 4 in the preprocessor config file).

@alex-jw-brooks is currently working on a PR that lets you pass options to the HF processor on demand instead of at startup time (the latter is what this PR focuses on). Stay tuned!

[alex-jw-brooks]

Hi @vpellegrain - thought I would link this PR if you'd like to track it, this exposes num_crops as an processor kwarg for phi3v, and can be used or both offline inference and in the CLI when starting the server entry point.

Happy to add a follow-up to make this configurable per-request later on, but as it was already turning into a lot of code to correctly handle processor kwargs for memory profiling etc, the current PR sets it up for init time 😄

[mergify]

This pull request has merge conflicts that must be resolved before it can be
merged. @KrishnaM251 please rebase it. https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

[DarkLight1337]

Sorry for forgetting about this! I think we now have a valid use case which is to patch out incorrect HF configs. cc @K-Mistele

[K-Mistele]

right, would be good to be able to adjust RoPE/YARN configurations in config.json at startup-time. I left comments about this on some other issues I just can't seem to find them right this second

[DarkLight1337]

I have updated this PR and also changed the tests to check overriding rope_scaling and rope_theta.

[DarkLight1337]

Since now we have a use case for this, I'm approving the PR.