Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Prefill Only Tokens Without KV Cache in Batch Requests (Disagg Prefill) #12285

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Shaoting-Feng
Copy link

@Shaoting-Feng Shaoting-Feng commented Jan 21, 2025

This ticket is part of [RFC]: Disaggregated Prefilling and KV Cache Transfer Roadmap #10818, with the following issue: "Adaptivity and Fault Tolerance: [Perf] If not all KV caches in the batch are received, only perform prefilling on those tokens without KV cache."

When there are multiple requests in a batch, the decode node may only receive the KV cache for some of them from the prefill node. Previously, in such cases, the decode node would perform prefilling for all requests in the batch, even if it had already received the KV cache for some requests.

This PR rebuilds the model input when the KV cache for some requests in the batch is missing, thereby preventing prefilling on those requests.

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@Shaoting-Feng Shaoting-Feng changed the title [Core] Perform Prefilling Only on Decode Node for Requests Without KV Cache from Prefill Node in a Batch [Core] Prefill Only Tokens Without KV Cache in Batch Requests (Disagg Prefill) Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant