Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NVIDIA Blackwell codegen #12271

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

johnnynunez
Copy link

@johnnynunez johnnynunez commented Jan 21, 2025

Blackwell B100/B200 codegen 10.0
Blackwell RTX 50 codegen 12.0

@johnnynunez johnnynunez changed the title NVIDIA Blackwell RTX50 codegen NVIDIA Blackwell codegen Jan 21, 2025
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot added documentation Improvements or additions to documentation ci/build labels Jan 21, 2025
@youkaichao
Copy link
Member

does it have some requirements on the nvcc version?

@johnnynunez
Copy link
Author

johnnynunez commented Jan 21, 2025

does it have some requirements on the nvcc version?

yes, cuda 12.7 for B100/B200 and cuda 12.8 for RTX50.
Flash attention: Dao-AILab/flash-attention#1436

in pytorch is greater than 12.6

@tlrmchlsmth
Copy link
Collaborator

does it have some requirements on the nvcc version?

yes, cuda 12.7 for B100/B200 and cuda 12.8 for RTX50. Flash attention: Dao-AILab/flash-attention#1436

in pytorch is greater than 12.6

Thanks, I saw the flash attention changes -- good to know about the B100/B200 vs RTX difference there

CMakeLists.txt Outdated Show resolved Hide resolved
@johnnynunez
Copy link
Author

does it have some requirements on the nvcc version?

yes, cuda 12.7 for B100/B200 and cuda 12.8 for RTX50. Flash attention: Dao-AILab/flash-attention#1436
in pytorch is greater than 12.6

Thanks, I saw the flash attention changes -- good to know about the B100/B200 vs RTX difference there

I know more information:
10.0 blackwell b100/b200
10.1 blackwell thor
11.0 blackwell digits? only this I have to ask it
12.0 blackwell rtx50

@johnnynunez
Copy link
Author

@tlrmchlsmth check it

@youkaichao
Copy link
Member

does it have some requirements on the nvcc version?

I mean, will it break old nvcc if old nvcc cannot recognize these arch numbers?

@johnnynunez
Copy link
Author

johnnynunez commented Jan 22, 2025

does it have some requirements on the nvcc version?

I mean, will it break old nvcc if old nvcc cannot recognize these arch numbers?

Yes, old nvcc can’t generate code for blackwell. I tried on rtx5090 using 12.6.3 and it’s not working(“unsupported architecture”). But new desktop blackwell has hopper capabilities like cuda thread clusters so it should work at the same 9.0 codegen.

this means that flash attention v3 it should be compatible and the upcoming versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/build documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants