Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VLM] Simplify post-processing of replacement info #12269

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

DarkLight1337
Copy link
Member

@DarkLight1337 DarkLight1337 commented Jan 21, 2025

It is common to have extra tokens in the prompt replacement which are not sent to the vision encoder. This PR adds a PromptReplacementDetails class which is used to indicate which part of the replacement corresponds to placeholder feature tokens to be overwritten by embeddings from the vision encoder.

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

Copy link
Collaborator

@Isotr0py Isotr0py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM!

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) January 21, 2025 15:17
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Jan 21, 2025
@simon-mo simon-mo disabled auto-merge January 22, 2025 00:48
@simon-mo simon-mo merged commit df76e5a into vllm-project:main Jan 22, 2025
51 of 62 checks passed
@DarkLight1337 DarkLight1337 deleted the prompt-repl-details branch January 22, 2025 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants