Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Remove comments re: pytorch for outlines + compressed-tensors dependencies #12260

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

tdoublep
Copy link
Member

@tdoublep tdoublep commented Jan 21, 2025

These comments cause both packages to be stripped out when running use_existing_torch.py, but the packages are required dependencies.

See discussion on #12255

cc @youkaichao

…ncies. These comments cause the packages to be stripped out when running use_existing_torch, but the packages are required dependencies.

Signed-off-by: Thomas Parnell <[email protected]>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot added the ci/build label Jan 21, 2025
@youkaichao youkaichao enabled auto-merge (squash) January 21, 2025 11:29
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Jan 21, 2025
@youkaichao
Copy link
Member

let's check if GH200 test succeeds.

@youkaichao youkaichao disabled auto-merge January 21, 2025 11:30
@youkaichao
Copy link
Member

oh GH200 test is not in the test suite, but only happens post-merge.

@youkaichao
Copy link
Member

@tdoublep do you have some GH200 machines to test it manually? the script is https://github.com/vllm-project/vllm/blob/main/.buildkite/run-gh200-test.sh

@youkaichao
Copy link
Member

outlines_core-0.1.26-cp312-cp312-manylinux_2_17_aarch64.manylinux2014_aarch64.whl
compressed_tensors-0.8.1-py3-none-any.whl.metadata

it seems it's working.

@youkaichao youkaichao merged commit 9a7c3a0 into vllm-project:main Jan 21, 2025
83 of 85 checks passed
@tdoublep tdoublep deleted the fix-custom-torch-deps branch January 21, 2025 14:34
tdoublep added a commit to IBM/vllm that referenced this pull request Jan 21, 2025
…ncies (#68)

I already tried to fix this using #66
but upstream didn't like that change (the behaviour to filter out
comments containing torch was intentional). After [some
discussion](vllm-project/vllm#12255), we agreed
on a different solution implemented in this PR. Note that I reverted the
changes from #66 by force pushing main.

Note this has already been merged upstream by
vllm-project/vllm#12260 but I'm cherry-picking
the fix here since it is blocking the CI builds.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/build ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants