Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Misc] Add Gemma2 GGUF support #12186

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Isotr0py
Copy link
Collaborator

@Isotr0py Isotr0py commented Jan 18, 2025

FIX #12000 (link existing issues this PR will resolve)

Signed-off-by: Isotr0py <[email protected]>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@summersonnn
Copy link

summersonnn commented Jan 21, 2025

@Isotr0py Hi. I couldn't wait until the merge and gave it a try. Got this:

File "/persistent/virtualenvs/llm/lib/python3.10/site-packages/torch/_tensor.py", line 983, in split
    return torch._VF.split_with_sizes(self, split_size, dim)
RuntimeError: split_with_sizes expects split_sizes to sum exactly to 8192 (input tensor's size at dimension -1), but got split_sizes=[8192, 4096, 4096]

during serving gemma-2-27b-it-Q4_K_M. any idea? I can post the full trace if you need.

vllm==0.6.6.post1 (+ your changes)
transformers==4.48.1
torch==2.5.1

@Isotr0py
Copy link
Collaborator Author

Isotr0py commented Jan 21, 2025

I see, seems that it's because of the incorrect head_dim due to gguf -> hf config conversion from transformers. The correct head_dim should be 128, while the value extracted from gguf is the default 256...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Support gemma2 GGUF architecture
2 participants