Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Kernel] Flash Attention 3 Support #12093

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

LucasWilkinson
Copy link
Contributor

@LucasWilkinson LucasWilkinson commented Jan 15, 2025

Most of the changes for FA3 are in vllm-flash-attn, but there was some changes required on vLLM side. Namely FA3 doesn't support cu_seqlens_k when using a paged kv cache, instead it uses seqused_k which is the kv seqlens. FA2 also supports seqused_k so we switch to using this for both FA3 and FA2 when dealing with a paged kv-cache in-order to maintain a common interface.

This currently mainly improves V1 performance, some throughput numbers:

env VLLM_FLASH_ATTN_VERSION=2 VLLM_USE_V1=1 python benchmarks/benchmark_throughput.py --model meta-llama/Llama-3.1-8B-Instruct --input-len 2048 --output-len 128 --max-num-batched-tokens 16384 
Throughput: 12.81 requests/s, 27872.21 total tokens/s, 1639.54 output tokens/s

env VLLM_FLASH_ATTN_VERSION=3 VLLM_USE_V1=1 python benchmarks/benchmark_throughput.py --model meta-llama/Llama-3.1-8B-Instruct --input-len 2048 --output-len 128 --max-num-batched-tokens 16384 
Throughput: 14.24 requests/s, 30986.15 total tokens/s, 1822.71 output tokens/s

env VLLM_FLASH_ATTN_VERSION=2 VLLM_USE_V1=0 python benchmarks/benchmark_throughput.py --model meta-llama/Llama-3.1-8B-Instruct --input-len 2048 --output-len 128 --max-num-batched-tokens 16384 
Throughput: 12.40 requests/s, 26991.51 total tokens/s, 1587.74 output tokens/s

env VLLM_FLASH_ATTN_VERSION=3 VLLM_USE_V1=0 python benchmarks/benchmark_throughput.py --model meta-llama/Llama-3.1-8B-Instruct --input-len 2048 --output-len 128 --max-num-batched-tokens 16384 
Throughput: 12.74 requests/s, 27714.72 total tokens/s, 1630.28 output tokens/s

env VLLM_FLASH_ATTN_VERSION=2 VLLM_USE_V1=0 python benchmarks/benchmark_throughput.py --model meta-llama/Llama-3.1-8B-Instruct --input-len 2048 --output-len 128 --max-num-batched-tokens 16384 --num-scheduler-steps 4
Throughput: 13.20 requests/s, 28726.44 total tokens/s, 1689.79 output tokens/s

env VLLM_FLASH_ATTN_VERSION=3 VLLM_USE_V1=0 python benchmarks/benchmark_throughput.py --model meta-llama/Llama-3.1-8B-Instruct --input-len 2048 --output-len 128 --max-num-batched-tokens 16384 --num-scheduler-steps 4
Throughput: 13.34 requests/s, 29029.89 total tokens/s, 1707.64 output tokens/s

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

Signed-off-by: Lucas Wilkinson <[email protected]>
Signed-off-by: Lucas Wilkinson <[email protected]>
Signed-off-by: Lucas Wilkinson <[email protected]>
Signed-off-by: Lucas Wilkinson <[email protected]>
Signed-off-by: Lucas Wilkinson <[email protected]>
Signed-off-by: Lucas Wilkinson <[email protected]>
Signed-off-by: Lucas Wilkinson <[email protected]>
Signed-off-by: Lucas Wilkinson <[email protected]>
Signed-off-by: Lucas Wilkinson <[email protected]>
Signed-off-by: Lucas Wilkinson <[email protected]>
Signed-off-by: Lucas Wilkinson <[email protected]>
@LucasWilkinson LucasWilkinson changed the title [WIP][Kernel] Flash Attention 3 Support [Kernel] Flash Attention 3 Support Jan 22, 2025
@LucasWilkinson LucasWilkinson marked this pull request as ready for review January 22, 2025 04:57
Copy link
Collaborator

@WoosukKwon WoosukKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Amazing work! This resolves the performance issue in V1! 🚀
Really appreciate it!

Copy link

mergify bot commented Jan 22, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @LucasWilkinson.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants