[Platform] Do not raise error if _Backend is not found #12023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
wangxiyuan
force-pushed
the
_backend_refactor_1
branch
from
9e5a540 to
b411241
Compare
wangxiyuan
commented
Jan 14, 2025
| attn_backend = backend_name_to_enum(attn_backend.get_name()) | ||
| if attn_backend in {_Backend.FLASH_ATTN, _Backend.FLASH_ATTN_VLLM_V1}: | ||
| attn_backend = _Backend.XFORMERS | ||
| backend = backend_name_to_enum(attn_backend.get_name()) |
There was a problem hiding this comment.
Rename here to make lint check happy
wangxiyuan
force-pushed
the
_backend_refactor_1
branch
from
b411241 to
850bce0
Compare
wangxiyuan
force-pushed
the
_backend_refactor_1
branch
2 times, most recently
from
9439f9e to
edb061b
Compare
github-actions
bot
added
the
ready
|
Please update the test to avoid the CI failure. |
wangxiyuan
force-pushed
the
_backend_refactor_1
branch
from
edb061b to
fd875db
Compare
wangxiyuan
force-pushed
the
_backend_refactor_1
branch
from
fd875db to
280ae90
Compare
Signed-off-by: wangxiyuan <[email protected]>
wangxiyuan
force-pushed
the
_backend_refactor_1
branch
from
280ae90 to
065ed53
Compare
Signed-off-by: Mengqing Cao <[email protected]>
ice-tong
pushed a commit
to ice-tong/vllm
that referenced
this pull request
Jan 18, 2025
…12023) Signed-off-by: wangxiyuan <[email protected]> Signed-off-by: Mengqing Cao <[email protected]> Co-authored-by: Mengqing Cao <[email protected]> Signed-off-by: ice-tong <[email protected]>
joennlae
pushed a commit
to 44ai-labs/vllm
that referenced
this pull request
Jan 19, 2025
…12023) Signed-off-by: wangxiyuan <[email protected]> Signed-off-by: Mengqing Cao <[email protected]> Co-authored-by: Mengqing Cao <[email protected]>
joennlae
pushed a commit
to 44ai-labs/vllm
that referenced
this pull request
Jan 19, 2025
…12023) Signed-off-by: wangxiyuan <[email protected]> Signed-off-by: Mengqing Cao <[email protected]> Co-authored-by: Mengqing Cao <[email protected]>
jikunshang
pushed a commit
to jikunshang/vllm
that referenced
this pull request
Jan 21, 2025
…12023) Signed-off-by: wangxiyuan <[email protected]> Signed-off-by: Mengqing Cao <[email protected]> Co-authored-by: Mengqing Cao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #11162
The out-of-tree platform may have a different _Backend for attention backend. Ignore the error if the input _Backend is not the one in-tree.