Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Platform] Add output for Attention Backend #11981

Merged
merged 2 commits into from
Jan 14, 2025
Merged

[Platform] Add output for Attention Backend #11981

merged 2 commits into from
Jan 14, 2025

Conversation

wangxiyuan
Copy link
Contributor

@wangxiyuan wangxiyuan commented Jan 13, 2025 •
edited by github-actions bot
Loading

Part for #11162

This PR make use_output check to attention backend. So that each backend can decide its own way.

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@wangxiyuan wangxiyuan force-pushed the _Backend_refactor branch 3 times, most recently from c71a247 to 443e427 Compare January 13, 2025 09:33
@wangxiyuan wangxiyuan mentioned this pull request Jan 14, 2025
Open
1 task
@wangxiyuan wangxiyuan changed the title Add output for Attention Backend [Platform] Add output for Attention Backend Jan 14, 2025
youkaichao
youkaichao reviewed Jan 14, 2025
View reviewed changes
vllm/attention/backends/blocksparse_attn.py Outdated
@@ -87,6 +87,8 @@ def __post_init__(self):

class BlocksparseFlashAttentionBackend(AttentionBackend):

use_output: bool = True
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it true?

Copy link
Contributor Author

@wangxiyuan wangxiyuan Jan 14, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Base on previous logic, it's true to keep the same as before. See L95.

While it should be False indeed after reading your PR #10822

@wangxiyuan
Use property
a50f429 
Signed-off-by: wangxiyuan <[email protected]>
youkaichao
youkaichao approved these changes Jan 14, 2025
View reviewed changes
Copy link
Member

@youkaichao youkaichao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

@youkaichao youkaichao enabled auto-merge (squash) January 14, 2025 12:04
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Jan 14, 2025
@youkaichao youkaichao mentioned this pull request Jan 14, 2025
Merged
@youkaichao youkaichao merged commit 2e0e017 into vllm-project:main Jan 14, 2025
68 checks passed
ice-tong pushed a commit to ice-tong/vllm that referenced this pull request Jan 18, 2025
@wangxiyuan @ice-tong
[Platform] Add output for Attention Backend (vllm-project#11981)
462d6a5 
Signed-off-by: wangxiyuan <[email protected]>
Signed-off-by: ice-tong <[email protected]>
joennlae pushed a commit to 44ai-labs/vllm that referenced this pull request Jan 19, 2025
@wangxiyuan
[Platform] Add output for Attention Backend (vllm-project#11981)
ded9ba9 
Signed-off-by: wangxiyuan <[email protected]>
joennlae pushed a commit to 44ai-labs/vllm that referenced this pull request Jan 19, 2025
@wangxiyuan
[Platform] Add output for Attention Backend (vllm-project#11981)
b133bcb 
Signed-off-by: wangxiyuan <[email protected]>
jikunshang pushed a commit to jikunshang/vllm that referenced this pull request Jan 21, 2025
@wangxiyuan @jikunshang
[Platform] Add output for Attention Backend (vllm-project#11981)
2dcf45f 
Signed-off-by: wangxiyuan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youkaichao youkaichao youkaichao approved these changes

@WoosukKwon WoosukKwon Awaiting requested review from WoosukKwon WoosukKwon is a code owner

@robertgshaw2-redhat robertgshaw2-redhat Awaiting requested review from robertgshaw2-redhat robertgshaw2-redhat is a code owner

@njhill njhill Awaiting requested review from njhill njhill is a code owner

@ywang96 ywang96 Awaiting requested review from ywang96 ywang96 is a code owner

@comaniac comaniac Awaiting requested review from comaniac comaniac is a code owner

@alexm-redhat alexm-redhat Awaiting requested review from alexm-redhat alexm-redhat is a code owner

@zhuohan123 zhuohan123 Awaiting requested review from zhuohan123 zhuohan123 is a code owner

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wangxiyuan @youkaichao