Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bugfix][Hardware][CPU] Fix CPU input_positions creation for text-only inputs with mrope #11434

Merged
merged 8 commits into from
Dec 24, 2024
Merged

[Bugfix][Hardware][CPU] Fix CPU input_positions creation for text-only inputs with mrope #11434

merged 8 commits into from
Dec 24, 2024

Conversation

Isotr0py
Copy link
Collaborator

@Isotr0py Isotr0py commented Dec 23, 2024 •
edited by github-actions bot
Loading

FIX #11154

  • MRope position should not be used to create input_positions for text-only inputs

@Isotr0py
fix cpu mrope
f5a2a13 
Signed-off-by: Isotr0py <[email protected]>
@Isotr0py
code format
e79a2bd 
Signed-off-by: Isotr0py <[email protected]>
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@Isotr0py Isotr0py mentioned this pull request Dec 23, 2024
Closed
1 task
DarkLight1337
DarkLight1337 approved these changes Dec 23, 2024
View reviewed changes
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@Isotr0py
fix vision inputs
9c66d68 
Signed-off-by: Isotr0py <[email protected]>
@Isotr0py
oops
cb5b1a3 
Signed-off-by: Isotr0py <[email protected]>
@Isotr0py
fix mrope disable
143f49f 
Signed-off-by: Isotr0py <[email protected]>
@Isotr0py
fix decoding
7d6a728 
Signed-off-by: Isotr0py <[email protected]>
@Isotr0py Isotr0py added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 24, 2024
@Isotr0py
fix mrope compute
25985eb 
Signed-off-by: Isotr0py <[email protected]>
@Isotr0py
code format
5a1f5f0 
Signed-off-by: Isotr0py <[email protected]>
@Isotr0py Isotr0py merged commit 7a5286c into vllm-project:main Dec 24, 2024
50 checks passed
@Isotr0py Isotr0py deleted the fix-cpu-mrope branch December 24, 2024 09:59
BKitor pushed a commit to BKitor/vllm that referenced this pull request Dec 30, 2024
@Isotr0py @BKitor
[Bugfix][Hardware][CPU] Fix CPU input_positions creation for text-o…
d2da51d 
…nly inputs with mrope (vllm-project#11434)

Signed-off-by: Isotr0py <[email protected]>
joennlae pushed a commit to 44ai-labs/vllm that referenced this pull request Jan 19, 2025
@Isotr0py
[Bugfix][Hardware][CPU] Fix CPU input_positions creation for text-o…
f51cb30 
…nly inputs with mrope (vllm-project#11434)

Signed-off-by: Isotr0py <[email protected]>
joennlae pushed a commit to 44ai-labs/vllm that referenced this pull request Jan 19, 2025
@Isotr0py
[Bugfix][Hardware][CPU] Fix CPU input_positions creation for text-o…
5735164 
…nly inputs with mrope (vllm-project#11434)

Signed-off-by: Isotr0py <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
2 participants
@Isotr0py @DarkLight1337