Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] torch nightly version in ROCm installation guide #11423

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

terrytangyuan
Copy link
Contributor

@terrytangyuan terrytangyuan commented Dec 23, 2024

This fixes the following error when using this guide:

Looking in indexes: https://download.pytorch.org/whl/nightly/rocm6.2
ERROR: Could not find a version that satisfies the requirement torch==2.6.0.dev20240918 (from versions: 2.6.0.dev20241024+rocm6.2, 2.6.0.dev20241026+rocm6.2, 2.6.0.dev20241027+rocm6.2, 2.6.0.dev20241028+rocm6.2, 2.6.0.dev20241029+rocm6.2, 2.6.0.dev20241030+rocm6.2, 2.6.0.dev20241031+rocm6.2, 2.6.0.dev20241101+rocm6.2, 2.6.0.dev20241102+rocm6.2, 2.6.0.dev20241103+rocm6.2, 2.6.0.dev20241104+rocm6.2, 2.6.0.dev20241105+rocm6.2, 2.6.0.dev20241106+rocm6.2, 2.6.0.dev20241107+rocm6.2, 2.6.0.dev20241108+rocm6.2, 2.6.0.dev20241109+rocm6.2, 2.6.0.dev20241110+rocm6.2, 2.6.0.dev20241111+rocm6.2, 2.6.0.dev20241112+rocm6.2, 2.6.0.dev20241113+rocm6.2, 2.6.0.dev20241114+rocm6.2, 2.6.0.dev20241115+rocm6.2, 2.6.0.dev20241116+rocm6.2, 2.6.0.dev20241117+rocm6.2, 2.6.0.dev20241118+rocm6.2, 2.6.0.dev20241119+rocm6.2, 2.6.0.dev20241120+rocm6.2, 2.6.0.dev20241121+rocm6.2, 2.6.0.dev20241122+rocm6.2)
ERROR: No matching distribution found for torch==2.6.0.dev20240918

References:

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot added the documentation Improvements or additions to documentation label Dec 23, 2024
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) December 23, 2024 14:30
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 23, 2024
@DarkLight1337 DarkLight1337 changed the title Fix torch nightly version in ROCm installation guide [Bugfix] torch nightly version in ROCm installation guide Dec 23, 2024
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) December 23, 2024 14:30
@DarkLight1337 DarkLight1337 merged commit 2e72668 into vllm-project:main Dec 23, 2024
48 of 50 checks passed
@terrytangyuan terrytangyuan deleted the fix-torch-version branch December 23, 2024 18:01
ayylemao pushed a commit to ayylemao/vllm that referenced this pull request Dec 24, 2024
BKitor pushed a commit to BKitor/vllm that referenced this pull request Dec 30, 2024
joennlae pushed a commit to 44ai-labs/vllm that referenced this pull request Jan 19, 2025
joennlae pushed a commit to 44ai-labs/vllm that referenced this pull request Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants