Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Model][BugFix] Mamba/Jamba exceed mamba cache slots #11414

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mzusman
Copy link
Contributor

@mzusman mzusman commented Dec 22, 2024

In recent vLLM versions (since v0.6.4) running requests are not capped anymore by scheduler_config.max_num_seqs which causes an issue on Jamba/Mamba models on high loads.
Mamba models keeps a state inside the modeling file and defines the max running sequences/slots as max_num_seqs. exceeding this number of slots causes an error that crashes vLLM.

to solve that, I've introduced an envar that multiplies the mamba cache slots by a certain amount (x1.5 by default) .
The default is x1.5 as I've seen it's quite sufficient in my tests.

CC @tlrmchlsmth

causing an error inside the mamba cache manager, setting the max num
seqs as twice as the max batch size, ensures that new requests will have
spare space in the mamba cache manager

Signed-off-by: mzusman <[email protected]>
Signed-off-by: mzusman <[email protected]>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

Copy link
Collaborator

@tlrmchlsmth tlrmchlsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should find a robust solution to this issue. Could you describe the situation that causes this a bit more (e.g. does it only happen for multistep or when running chunked prefill?).

Do you have a command to repro this problem? The commit where this started happening would help nail exactly what's happening

Copy link

mergify bot commented Dec 29, 2024

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @mzusman.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants