Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bugfix] Fix broken CPU compressed-tensors test #11338

Merged
merged 2 commits into from
Dec 19, 2024
Merged

[Bugfix] Fix broken CPU compressed-tensors test #11338

merged 2 commits into from
Dec 19, 2024

Conversation

Isotr0py
Copy link
Collaborator

@Isotr0py Isotr0py commented Dec 19, 2024 •
edited by github-actions bot
Loading

@Isotr0py
fix broken CPU test
d8e6243 
Signed-off-by: Isotr0py <[email protected]>
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@Isotr0py Isotr0py added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 19, 2024
@Isotr0py
remove comments
c2d2349 
Signed-off-by: Isotr0py <[email protected]>
tlrmchlsmth
tlrmchlsmth approved these changes Dec 19, 2024
View reviewed changes
Copy link
Collaborator

@tlrmchlsmth tlrmchlsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix!

@Isotr0py Isotr0py enabled auto-merge (squash) December 19, 2024 15:31
@Isotr0py Isotr0py merged commit 276738c into vllm-project:main Dec 19, 2024
54 checks passed
@Isotr0py Isotr0py deleted the fix-cpu-test branch December 19, 2024 17:50
BKitor pushed a commit to BKitor/vllm that referenced this pull request Dec 30, 2024
@Isotr0py @BKitor
[Bugfix] Fix broken CPU compressed-tensors test (vllm-project#11338)
9f9277d 
Signed-off-by: Isotr0py <[email protected]>
joennlae pushed a commit to 44ai-labs/vllm that referenced this pull request Jan 19, 2025
@Isotr0py
[Bugfix] Fix broken CPU compressed-tensors test (vllm-project#11338)
01de6fe 
Signed-off-by: Isotr0py <[email protected]>
joennlae pushed a commit to 44ai-labs/vllm that referenced this pull request Jan 19, 2025
@Isotr0py
[Bugfix] Fix broken CPU compressed-tensors test (vllm-project#11338)
7a7e121 
Signed-off-by: Isotr0py <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 left review comments

@tlrmchlsmth tlrmchlsmth tlrmchlsmth approved these changes

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Isotr0py @tlrmchlsmth @DarkLight1337