[Bugfix][Hardware][POWERPC] Fix auto dtype failure in case of POWER10 #11331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
Signed-off-by: Akash Kaothalkar <[email protected]>
Signed-off-by: Akash Kaothalkar <[email protected]>
Akashcodes732
force-pushed
the
fix/auto-dtype
branch
from
d663ebd to
616e760
Compare
mgoin
approved these changes
Dec 20, 2024
lucas-tucker
pushed a commit
to lucas-tucker/vllm-lucas-tucker
that referenced
this pull request
Dec 21, 2024
…vllm-project#11331) Signed-off-by: Akash Kaothalkar <[email protected]> Signed-off-by: lucast2021 <[email protected]>
BKitor
pushed a commit
to BKitor/vllm
that referenced
this pull request
Dec 30, 2024
…vllm-project#11331) Signed-off-by: Akash Kaothalkar <[email protected]>
joennlae
pushed a commit
to 44ai-labs/vllm
that referenced
this pull request
Jan 19, 2025
…vllm-project#11331) Signed-off-by: Akash Kaothalkar <[email protected]>
joennlae
pushed a commit
to 44ai-labs/vllm
that referenced
this pull request
Jan 19, 2025
…vllm-project#11331) Signed-off-by: Akash Kaothalkar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIX #11327
This PR fixes the
dtype="auto"failure in case of POWEPC.The failure observed in above issue was due to FP16 not supported in ppc64le architecture. With this PR we are making changes to select BF16 instead of FP16 when "auto" type is selected.