Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Misc] Allow passing logits_soft_cap for xformers backend #11252

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

Isotr0py
Copy link
Collaborator

@Isotr0py Isotr0py commented Dec 17, 2024

"The Gemma 2 team observed very minor differences when soft-capping is removed during inference." (https://huggingface.co/blog/gemma2#soft-capping-and-attention-implementations)

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) December 17, 2024 06:03
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 17, 2024
@youkaichao youkaichao disabled auto-merge December 17, 2024 08:36
@youkaichao youkaichao merged commit f9ecbb1 into vllm-project:main Dec 17, 2024
65 of 69 checks passed
@Isotr0py Isotr0py deleted the fix-xformers branch December 17, 2024 09:31
BKitor pushed a commit to BKitor/vllm that referenced this pull request Dec 30, 2024
joennlae pushed a commit to 44ai-labs/vllm that referenced this pull request Jan 19, 2025
joennlae pushed a commit to 44ai-labs/vllm that referenced this pull request Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants