Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[V1][Core] Use weakref.finalize instead of atexit #11242

Merged
merged 2 commits into from
Dec 17, 2024
Merged

[V1][Core] Use weakref.finalize instead of atexit #11242

merged 2 commits into from
Dec 17, 2024

Conversation

tlrmchlsmth
Copy link
Collaborator

@tlrmchlsmth tlrmchlsmth commented Dec 16, 2024 •
edited
Loading

It's nicer this way, since we no longer need to unregister shutdown from atexit

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@tlrmchlsmth
format
59cc328 
Signed-off-by: Tyler Michael Smith <[email protected]>
DarkLight1337
DarkLight1337 approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up!

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) December 17, 2024 03:57
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 17, 2024
@youkaichao youkaichao disabled auto-merge December 17, 2024 06:11
@youkaichao youkaichao merged commit 2bfdbf2 into vllm-project:main Dec 17, 2024
59 of 64 checks passed
@youkaichao youkaichao deleted the weakref_finalize branch December 17, 2024 06:11
BKitor pushed a commit to BKitor/vllm that referenced this pull request Dec 30, 2024
@tlrmchlsmth @BKitor
[V1][Core] Use weakref.finalize instead of atexit (vllm-project#11242)
783bbeb 
Signed-off-by: Tyler Michael Smith <[email protected]>
joennlae pushed a commit to 44ai-labs/vllm that referenced this pull request Jan 19, 2025
@tlrmchlsmth
[V1][Core] Use weakref.finalize instead of atexit (vllm-project#11242)
4f77d97 
Signed-off-by: Tyler Michael Smith <[email protected]>
joennlae pushed a commit to 44ai-labs/vllm that referenced this pull request Jan 19, 2025
@tlrmchlsmth
[V1][Core] Use weakref.finalize instead of atexit (vllm-project#11242)
c91671a 
Signed-off-by: Tyler Michael Smith <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

@WoosukKwon WoosukKwon Awaiting requested review from WoosukKwon WoosukKwon is a code owner

@robertgshaw2-redhat robertgshaw2-redhat Awaiting requested review from robertgshaw2-redhat robertgshaw2-redhat is a code owner

@njhill njhill Awaiting requested review from njhill njhill is a code owner

@ywang96 ywang96 Awaiting requested review from ywang96 ywang96 is a code owner

@comaniac comaniac Awaiting requested review from comaniac comaniac is a code owner

@alexm-redhat alexm-redhat Awaiting requested review from alexm-redhat alexm-redhat is a code owner

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tlrmchlsmth @DarkLight1337 @youkaichao