Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bugfix]: Clamp -inf logprob values in prompt_logprobs #11073

Merged
merged 1 commit into from
Dec 11, 2024
Merged

[Bugfix]: Clamp -inf logprob values in prompt_logprobs #11073

merged 1 commit into from
Dec 11, 2024

Conversation

rafvasq
Copy link
Contributor

@rafvasq rafvasq commented Dec 10, 2024 •
edited by github-actions bot
Loading

Logprobs with an -inf value are clamped to -9999.0 in other parts of the code but not here, resulting in a JSON compliance error in cases where the top_k sampling parameter is used too.

Fixes #10234

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot added the frontend label Dec 10, 2024
@rafvasq rafvasq changed the title fix: Clamp -inf logprob values in prompt_logprobs [Bugfix]: Clamp -inf logprob values in prompt_logprobs Dec 10, 2024
DarkLight1337
DarkLight1337 approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) December 11, 2024 04:10
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 11, 2024
@youkaichao youkaichao disabled auto-merge December 11, 2024 09:27
@youkaichao youkaichao merged commit 40766ca into vllm-project:main Dec 11, 2024
61 of 63 checks passed
@rafvasq rafvasq deleted the investigate-top-k branch December 11, 2024 16:00
Akshat-Tripathi pushed a commit to krai/vllm that referenced this pull request Dec 12, 2024
@rafvasq @Akshat-Tripathi
[Bugfix]: Clamp -inf logprob values in prompt_logprobs (vllm-projec…
3f95b8a 
…t#11073)

Signed-off-by: Rafael Vasquez <[email protected]>
Signed-off-by: Akshat Tripathi <[email protected]>
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
@rafvasq
[Bugfix]: Clamp -inf logprob values in prompt_logprobs (vllm-projec…
9d0089a 
…t#11073)

Signed-off-by: Rafael Vasquez <[email protected]>
BKitor pushed a commit to BKitor/vllm that referenced this pull request Dec 30, 2024
@rafvasq @BKitor
[Bugfix]: Clamp -inf logprob values in prompt_logprobs (vllm-projec…
e1e18de 
…t#11073)

Signed-off-by: Rafael Vasquez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

Assignees
No one assigned
Labels
frontend ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Internal Server Error when echo'ing logprobs with sampling
3 participants
@rafvasq @DarkLight1337 @youkaichao