[V1][Bugfix] Always set enable_chunked_prefill = True for V1 #11061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Woosuk Kwon <[email protected]>
|
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
WoosukKwon
changed the title
Signed-off-by: Woosuk Kwon <[email protected]>
comaniac
reviewed
Dec 10, 2024
Signed-off-by: Woosuk Kwon <[email protected]>
comaniac
approved these changes
Dec 10, 2024
github-actions
bot
added
the
ready
Akshat-Tripathi
pushed a commit
to krai/vllm
that referenced
this pull request
Dec 12, 2024
…oject#11061) Signed-off-by: Woosuk Kwon <[email protected]> Signed-off-by: Akshat Tripathi <[email protected]>
sleepwalker2017
pushed a commit
to sleepwalker2017/vllm
that referenced
this pull request
Dec 13, 2024
…oject#11061) Signed-off-by: Woosuk Kwon <[email protected]>
BKitor
pushed a commit
to BKitor/vllm
that referenced
this pull request
Dec 30, 2024
…oject#11061) Signed-off-by: Woosuk Kwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in initializing the OpenAI server with V1: Currently, the server fails for some models with the error message:
ValueError: max_num_batched_tokens (2048) is smaller than max_model_len (8192).This is becauseenable_chunked_prefillis not properly set.