Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI/Build] Check transformers v4.47 #10991

Merged
merged 3 commits into from
Dec 11, 2024
Merged

[CI/Build] Check transformers v4.47 #10991

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
144dfad
Test transformers v4.47
DarkLight1337 Dec 8, 2024
a3bfaa5
Update skip decorators
DarkLight1337 Dec 9, 2024
d112276
Merge branch 'main' into test-transformers-447
DarkLight1337 Dec 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions requirements-test.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -516,7 +516,7 @@ tiktoken==0.7.0
# mistral-common
timm==1.0.11
# via -r requirements-test.in
tokenizers==0.20.3
tokenizers==0.21.0
# via transformers
toml==0.10.2
# via datamodel-code-generator
Expand Down Expand Up @@ -550,7 +550,7 @@ tqdm==4.66.6
# transformers
tqdm-multiprocess==0.0.11
# via lm-eval
transformers==4.46.3
transformers==4.47.0
# via
# lm-eval
# peft
Expand Down
9 changes: 0 additions & 9 deletions tests/models/decoder_only/vision_language/mm_processor_kwargs/test_idefics3.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@

import pytest
import torch
import transformers
from transformers import AutoImageProcessor, AutoTokenizer

from vllm.inputs import InputContext, token_inputs
Expand Down Expand Up @@ -36,8 +35,6 @@ def get_max_idefics3_image_tokens():
return get_max_idefics3_image_tokens


@pytest.mark.skipif(transformers.__version__ < "4.46.0",
reason="Model introduced in HF >= 4.46.0")
@pytest.mark.parametrize("model", models)
@pytest.mark.parametrize("longest_edge", [None, 168, 336, 400, 2 * 336])
def test_input_mapper_override(model: str, image_assets: _ImageAssets,
Expand Down Expand Up @@ -77,8 +74,6 @@ def test_input_mapper_override(model: str, image_assets: _ImageAssets,
assert torch.all(hf_result["pixel_values"] == vllm_result["pixel_values"])


@pytest.mark.skipif(transformers.__version__ < "4.46.0",
reason="Model introduced in HF >= 4.46.0")
@pytest.mark.parametrize("model", models)
@pytest.mark.parametrize("longest_edge, expected_max_tokens", [
(None, 2873),
Expand Down Expand Up @@ -107,8 +102,6 @@ def test_max_tokens_override(get_max_idefics3_image_tokens, model: str,
assert expected_max_tokens == actual_max_tokens


@pytest.mark.skipif(transformers.__version__ < "4.46.0",
reason="Model introduced in HF >= 4.46.0")
@pytest.mark.parametrize("model", models)
@pytest.mark.parametrize("longest_edge, toks_per_img, num_imgs", [
(168, 169, 1),
Expand Down Expand Up @@ -143,8 +136,6 @@ def test_dummy_data_override(dummy_data_for_idefics3, model: str,
assert img_tok_count == toks_per_img * num_imgs


@pytest.mark.skipif(transformers.__version__ < "4.46.0",
reason="Model introduced in HF >= 4.46.0")
@pytest.mark.parametrize("model", models)
@pytest.mark.parametrize("longest_edge,expected_toks_per_img,num_imgs", [
(336, 169 * (1**2 + 1), 1),
Expand Down
2 changes: 1 addition & 1 deletion tests/models/embedding/vision_language/test_llava_next.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ def _run_test(
)


@pytest.mark.skipif(transformers.__version__.startswith("4.46"),
@pytest.mark.skipif(transformers.__version__ >= "4.46",
reason="Model broken with changes in transformers 4.46")
@pytest.mark.core_model
@pytest.mark.parametrize("model", MODELS)
Expand Down
Loading