Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] fix broken tests #10956

Merged
merged 1 commit into from
Dec 6, 2024
Merged

[ci] fix broken tests #10956

merged 1 commit into from
Dec 6, 2024

Conversation

youkaichao
Copy link
Member

Signed-off-by: youkaichao <[email protected]>
Copy link

github-actions bot commented Dec 6, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@youkaichao
Copy link
Member Author

this should fix the

list index out of range

error in https://buildkite.com/vllm/ci/builds/10303#01939a57-bf9d-4e2f-8d32-384b5c5077e2 .

for

ValueError: Multi-Step not supported for attention backend: NO_ATTENTION. Set VLLM_ATTENTION_BACKEND to a value from ['FLASH_ATTN', 'ROCM_FLASH', 'FLASHINFER'].

I have pinged @tlrmchlsmth , it should be #10705

@youkaichao youkaichao marked this pull request as ready for review December 6, 2024 17:06
@youkaichao youkaichao requested a review from KuntaiDu December 6, 2024 18:43
Copy link
Collaborator

@KuntaiDu KuntaiDu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@youkaichao youkaichao merged commit dcdc3fa into vllm-project:main Dec 6, 2024
24 checks passed
@youkaichao youkaichao deleted the fix_disagg branch December 6, 2024 19:25
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
BKitor pushed a commit to BKitor/vllm that referenced this pull request Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants