Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Benchmark] Add new H100 machine #10547

Merged
merged 4 commits into from
Nov 22, 2024
Merged

[Benchmark] Add new H100 machine #10547

merged 4 commits into from
Nov 22, 2024

Conversation

simon-mo
Copy link
Collaborator

@simon-mo simon-mo commented Nov 21, 2024 •
edited by github-actions bot
Loading

This PR re-enables the H100 test after setting one machine from Nebius (thank you!)

Successful run: https://buildkite.com/vllm/performance-benchmark/builds/9555#019350db-3fee-43cf-9449-b125f1d926dc

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot added the ci/build label Nov 21, 2024
@simon-mo simon-mo enabled auto-merge (squash) November 22, 2024 01:55
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 22, 2024
KuntaiDu
KuntaiDu approved these changes Nov 22, 2024
View reviewed changes
Copy link
Collaborator

@KuntaiDu KuntaiDu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simon-mo simon-mo merged commit aed0748 into vllm-project:main Nov 22, 2024
28 of 45 checks passed
tlrmchlsmth pushed a commit to neuralmagic/vllm that referenced this pull request Nov 23, 2024
@simon-mo @tlrmchlsmth
[Benchmark] Add new H100 machine (vllm-project#10547)
3e4efea 
Signed-off-by: Tyler Michael Smith <[email protected]>
mfournioux pushed a commit to mfournioux/vllm that referenced this pull request Nov 28, 2024
@simon-mo @mfournioux
[Benchmark] Add new H100 machine (vllm-project#10547)
33ba8f3 
Signed-off-by: Maxime Fournioux <[email protected]>
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
@simon-mo
[Benchmark] Add new H100 machine (vllm-project#10547)
91b7769
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KuntaiDu KuntaiDu KuntaiDu approved these changes

Assignees
No one assigned
Labels
ci/build perf-benchmarks ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simon-mo @KuntaiDu