[CI/Build] Make shellcheck happy

[DarkLight1337]

This PR fixes the INFO-level issues when running format.sh locally. cc @russellb

To avoid similar issues in the future, shellcheck.sh has been updated to fail CI when this happens.

[github-actions]

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

• Add ready label to the PR
• Enable auto-merge.

🚀

[russellb]

The changes look good.

It's an accident that this isn't failing CI! If you want, you could add set -ex to tools/shellcheck.sh, which I think will fix that. Otherwise, I can do it in a follow-up PR.

[DarkLight1337]

I added this line to shellcheck.sh, but format.sh still outputs "Format check passed!" even when the return code is non-zero.

[russellb]

I added this line to shellcheck.sh, but format.sh still outputs "Format check passed!" even when the return code is non-zero.

OK, I'll look into it.

[russellb]

This change works for me:

diff --git a/tools/shellcheck.sh b/tools/shellcheck.sh
index a13c49eb..d99fa77b 100755
--- a/tools/shellcheck.sh
+++ b/tools/shellcheck.sh
@@ -19,4 +19,4 @@ if ! [ -x "$(command -v shellcheck)" ]; then
 fi
 
 # TODO - fix warnings in .buildkite/run-amd-test.sh
-find . -name "*.sh" -not -path "./.buildkite/run-amd-test.sh" -exec sh -c 'git check-ignore -q $1 || shellcheck $1' _ {} \;
+find . -name "*.sh" -not -path "./.buildkite/run-amd-test.sh" -print0 | xargs -0 -I {} sh -c 'git check-ignore -q "{}" || shellcheck "{}"'

[russellb]

lgtm, sorry for the trouble!

[DarkLight1337]

@youkaichao can you stamp this?