Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LoRA][Kernel] Remove the unused libentry module #10214

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

jeejeelee
Copy link
Collaborator

vLLM's current Triton version is 3.1.0, it's safe to remove the libentry module. See: #5036 (comment)
ping @DarkLight1337

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

Signed-off-by: Jee Jee Li <[email protected]>
@DarkLight1337
Copy link
Member

The triton version doesn't appear to be specified for all vLLM backends.

@jeejeelee
Copy link
Collaborator Author

The triton version doesn't appear to be specified for all vLLM backends.

The current triton in vLLM comes from PyTorch, so it might be safe to remove it.

@DarkLight1337
Copy link
Member

Can you point to where I can find that information?

@jeejeelee
Copy link
Collaborator Author

Can you point to where I can find that information?

See: #4061

@DarkLight1337
Copy link
Member

I see, thanks. In that case let's merge this.

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) November 11, 2024 08:25
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 11, 2024
@jeejeelee
Copy link
Collaborator Author

I see, thanks. In that case let's merge this.

Thanks.
On one hand, libentry indeed doesn't have much use for the current vllm anymore.
Another reason is that libentry has a potential risk that prevents triton kernels from completing multi-GPU testing, which means we cannot verify whether issues like #9794 can be resolved.

@DarkLight1337 DarkLight1337 merged commit 36e4acd into vllm-project:main Nov 11, 2024
64 checks passed
jeejeelee added a commit to jeejeelee/vllm that referenced this pull request Nov 11, 2024
@jeejeelee jeejeelee deleted the delete-libentry branch November 11, 2024 16:46
rickyyx pushed a commit to rickyyx/vllm that referenced this pull request Nov 13, 2024
sumitd2 pushed a commit to sumitd2/vllm that referenced this pull request Nov 14, 2024
KuntaiDu pushed a commit to KuntaiDu/vllm that referenced this pull request Nov 20, 2024
mfournioux pushed a commit to mfournioux/vllm that referenced this pull request Nov 20, 2024
tlrmchlsmth pushed a commit to neuralmagic/vllm that referenced this pull request Nov 23, 2024
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants