-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LoRA][Kernel] Remove the unused libentry module #10214
Conversation
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
Signed-off-by: Jee Jee Li <[email protected]>
32b10f1
to
c048f22
Compare
The triton version doesn't appear to be specified for all vLLM backends. |
The current triton in vLLM comes from PyTorch, so it might be safe to remove it. |
Can you point to where I can find that information? |
See: #4061 |
I see, thanks. In that case let's merge this. |
Thanks. |
Signed-off-by: Jee Jee Li <[email protected]>
Signed-off-by: Jee Jee Li <[email protected]>
Signed-off-by: Jee Jee Li <[email protected]> Signed-off-by: Sumit Dubey <[email protected]>
Signed-off-by: Jee Jee Li <[email protected]>
Signed-off-by: Jee Jee Li <[email protected]> Signed-off-by: Maxime Fournioux <[email protected]>
Signed-off-by: Jee Jee Li <[email protected]> Signed-off-by: Tyler Michael Smith <[email protected]>
Signed-off-by: Jee Jee Li <[email protected]>
vLLM's current Triton version is
3.1.0
, it's safe to remove thelibentry
module. See: #5036 (comment)ping @DarkLight1337