-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI/Build] change conflict PR comment from mergify #10080
Conversation
On PRs opened by dependabot, this comment is interpreted by dependabot as a command to rebase the PR. We don't need the bots telling each other what to do. An example is vllm-project#9746. The simplest change is to update the text so it will no longer be interpreted as a command by dependabot. We do that by putting the "rebase" word prior to the username mention. Signed-off-by: Russell Bryant <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing!
Signed-off-by: Russell Bryant <[email protected]> Signed-off-by: Loc Huynh <[email protected]>
Signed-off-by: Russell Bryant <[email protected]> Signed-off-by: Sumit Dubey <[email protected]>
Signed-off-by: Russell Bryant <[email protected]>
Signed-off-by: Russell Bryant <[email protected]> Signed-off-by: Maxime Fournioux <[email protected]>
Signed-off-by: Russell Bryant <[email protected]> Signed-off-by: Tyler Michael Smith <[email protected]>
Signed-off-by: Russell Bryant <[email protected]>
On PRs opened by dependabot, this comment is interpreted by dependabot
as a command to rebase the PR. We don't need the bots telling each
other what to do. An example is #9746.
The simplest change is to update the text so it will no longer be
interpreted as a command by dependabot. We do that by putting the
"rebase" word prior to the username mention.
Signed-off-by: Russell Bryant [email protected]