Skip to content

Commit

Permalink
Fix formatting and test case
Browse files Browse the repository at this point in the history
Signed-off-by: Sumit Vij <[email protected]>
  • Loading branch information
thedebugger committed Jan 11, 2025
1 parent 317fc38 commit dd686e3
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 4 deletions.
4 changes: 2 additions & 2 deletions tests/lora/test_ultravox.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

VLLM_PLACEHOLDER = "<|reserved_special_token_0|>"

PROMPT = "Tell me about a silly chess move in 20 words"
PROMPT = "Tell me about a Fool's mate move in 20 words. Provide the moves!"


def llama3_1_8b_chess_lora_path():
Expand Down Expand Up @@ -60,7 +60,7 @@ def _get_prompt(audio_count, question, placeholder, model_name) -> str:
add_generation_prompt=True)


def test_ultravox_lora(vllm_runner, ):
def test_ultravox_lora(vllm_runner):
llama3_1_8b_chess_lora = llama3_1_8b_chess_lora_path()
with TemporaryDirectory() as temp_ultravox_lora_dir:
llama3_1_8b_ultravox_chess_lora = mk_llama3_1_8b_ultravox_chess_lora(
Expand Down
1 change: 0 additions & 1 deletion vllm/lora/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -407,7 +407,6 @@ def activate_adapter(
module_lora.bias)
else:
module.reset_lora(index)

return True

def _deactivate_adapter(self, lora_id: int):
Expand Down
1 change: 0 additions & 1 deletion vllm/model_executor/models/ultravox.py
Original file line number Diff line number Diff line change
Expand Up @@ -346,7 +346,6 @@ def forward(
return hidden_states



@MULTIMODAL_REGISTRY.register_processor(UltravoxMultiModalProcessor,
info=UltravoxProcessingInfo,
dummy_inputs=UltravoxDummyInputsBuilder
Expand Down

0 comments on commit dd686e3

Please sign in to comment.