Skip to content

Commit

Permalink
Move pymarkdownlnt to pre-commit
Browse files Browse the repository at this point in the history
Signed-off-by: Harry Mellor <[email protected]>
  • Loading branch information
hmellor committed Jan 12, 2025
1 parent 52b6433 commit 4dc3b61
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 44 deletions.
32 changes: 0 additions & 32 deletions .github/workflows/doc-lint.yml

This file was deleted.

8 changes: 6 additions & 2 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,9 @@ repos:
hooks:
- id: isort
# codespell
# isort
# clang-format
# clang-format
- repo: https://github.com/jackdewinter/pymarkdown
rev: v0.9.27
hooks:
- id: pymarkdown
files: docs/.*
6 changes: 0 additions & 6 deletions format.sh
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ check_command clang-format
MYPY_VERSION=$(mypy --version | awk '{print $2}')
CODESPELL_VERSION=$(codespell --version)
CLANGFORMAT_VERSION=$(clang-format --version | awk '{print $3}')
PYMARKDOWNLNT_VERSION=$(pymarkdownlnt version | awk '{print $1}')

# # params: tool name, tool version, required version
tool_version_check() {
Expand All @@ -49,7 +48,6 @@ tool_version_check() {
tool_version_check "mypy" "$MYPY_VERSION"
tool_version_check "codespell" "$CODESPELL_VERSION"
tool_version_check "clang-format" "$CLANGFORMAT_VERSION"
tool_version_check "pymarkdownlnt" "$PYMARKDOWNLNT_VERSION"

# Run mypy
echo 'vLLM mypy:'
Expand Down Expand Up @@ -176,7 +174,3 @@ if ! git diff --quiet &>/dev/null; then
else
echo "✨🎉 Format check passed! Congratulations! 🎉✨"
fi

echo 'vLLM doc-lint:'
tools/doc-lint.sh
echo 'vLLM doc-lint: Done'
1 change: 0 additions & 1 deletion requirements-lint.txt
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ toml==0.10.2
tomli==2.0.2
codespell==2.3.0
clang-format==18.1.5
pymarkdownlnt==0.9.26

# type checking
mypy==1.11.1
Expand Down
3 changes: 0 additions & 3 deletions tools/doc-lint.sh

This file was deleted.

0 comments on commit 4dc3b61

Please sign in to comment.