Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): execute with node22 #347

Merged
merged 2 commits into from
Jan 9, 2025
Merged

chore(ci): execute with node22 #347

merged 2 commits into from
Jan 9, 2025

Conversation

sapphi-red
Copy link
Member

same with #262 but for node 22

@sapphi-red
Copy link
Member Author

@sapphi-red
Copy link
Member Author

sapphi-red commented Dec 24, 2024

additional failing suites

  • analog
  • vike
  • plugin-vue

@dominikg
Copy link
Collaborator

dominikg commented Jan 1, 2025

hmm, why would switching to node22 make vike or analog fail?

cc @brillout @brandonroberts

@brandonroberts
Copy link
Contributor

hmm, why would switching to node22 make vike or analog fail?

cc @brillout @brandonroberts

I think this is a flakey test on the Analog side and not specifically tied to node22. See if a re-run fixes it for your CI

@brillout
Copy link
Contributor

brillout commented Jan 1, 2025

hmm, why would switching to node22 make vike or analog fail?

cc @brillout @brandonroberts

It was already fixed last week. (In case you're curious: it was just some new Node.js warning that Vike's CI didn't whitelist yet.) Let me know if Vike still fails and I'll have another look at it.

@dominikg
Copy link
Collaborator

dominikg commented Jan 2, 2025

triggered a rerun, looks like vike and analog passed, and the fails are similar to the last scheduled run, so this should be good to go. The change to deno@2 can be in a separate PR

Copy link
Collaborator

@dominikg dominikg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blocked by error caused by vmthreads use in analog testsuite, see https://discord.com/channels/804011606160703521/1324320073460088894

@sapphi-red sapphi-red dismissed dominikg’s stale review January 9, 2025 23:36

analog is now working

@sapphi-red sapphi-red merged commit f962520 into main Jan 9, 2025
3 checks passed
@sapphi-red sapphi-red deleted the chore/node22 branch January 9, 2025 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants