Add 30 second timeout to CurlAgent #308
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tatsh
changed the title
|
That would also timeout when syncing large files, am I right? |
|
I am not sure what the behaviour is now since I haven't had corrupted files transfer with this patch. I've transferred multi-GB files with this patch enabled. I'll have to check again on my machine with a large file. |
|
Ran my patched version (built locally) with a 26.3 GiB file and it works. This took much longer than 30 seconds to upload. I verified the checksums of the file after re-downloading it from Drive via web browser. The issue I was having before was that on macOS it would hang forever if anything went wrong with the connection, which was bad for timed jobs. This solved the issue. But now on macOS the #307 PR code should be used instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #306