Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: E2E tests maintenance #1966

Merged
merged 12 commits into from
Jan 13, 2025
Merged

chore: E2E tests maintenance #1966

merged 12 commits into from
Jan 13, 2025

Conversation

bprusinowski
Copy link
Collaborator

@bprusinowski bprusinowski commented Jan 10, 2025 •
edited
Loading

Closes #1950

This PR:

  • improves performance of E2E tests by using cached LINDAS endpoints,
  • cleans up unused chart config fixtures (and switches from dev to test naming convention for them),
  • enables localized abbreviations test on CI, as it seems to work correctly now,
  • adds two new E2E tests for chart duplication and image download.

@vercel Vercel
Copy link

vercel bot commented Jan 10, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
visualization-tool ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 13, 2025 7:51am

@bprusinowski bprusinowski marked this pull request as ready for review January 10, 2025 15:44
@bprusinowski bprusinowski changed the title test: E2E tests maintenance chore: E2E tests maintenance Jan 10, 2025
noahonyejese
noahonyejese approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@noahonyejese noahonyejese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

e2e/chart-actions.spec.ts Show resolved Hide resolved
@bprusinowski bprusinowski merged commit 03585ef into main Jan 13, 2025
6 of 7 checks passed
@bprusinowski bprusinowski deleted the test/e2e-maintenance branch January 13, 2025 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noahonyejese noahonyejese noahonyejese approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Review and add missing E2E tests
2 participants
@bprusinowski @noahonyejese