Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Table issues #1351

Merged
merged 3 commits into from
Feb 21, 2024
Merged

fix: Table issues #1351

merged 3 commits into from
Feb 21, 2024

Conversation

bprusinowski
Copy link
Collaborator

@bprusinowski bprusinowski commented Feb 20, 2024 •
edited
Loading

This PR:

  • disables "Interactive" toggle for temporal dimension in table charts, as we can't use interactive filters with tables,
  • fixes empty select elements in tables.

How to test

Fixed version (PR)

  1. Go to this link.
  2. Switch to a table chart.
  3. Select Kanton column.
  4. See that the select elements are filled.
Screenshot 2024-02-20 at 15 17 04
  1. Go to Jahr der Vergütung column.
  2. See that the "Interactive" toggle is not here.

Broken version (TEST, INT, PROD)
Go to this link and repeat the steps above to see how the state is currently broken.

@vercel Vercel
Copy link

vercel bot commented Feb 20, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
visualization-tool ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 20, 2024 2:26pm

@bprusinowski bprusinowski mentioned this pull request Feb 20, 2024
Closed
@bprusinowski bprusinowski merged commit c082fa9 into main Feb 21, 2024
5 of 7 checks passed
@bprusinowski bprusinowski deleted the fix/tables branch February 21, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptbrowne ptbrowne ptbrowne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bprusinowski @ptbrowne