fix: Navigation issue with metadata not showing up #1247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...to avoid jumping filters behavior. In this commit we also retrieve filters from previous query param to keep them defined.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue of metadata panel not showing in dataset preview when some filters were applied prior to navigating there.
The problem was that the
AnimationPresence'sonExitAnimationwas not triggered, probably related to nesting ofAnimatePresenceswith layout animations, some bugs with exit layout animations have been reported e.g. here. Wrapping theSearchFilters' children withAnimatePresencefixed the error.To reproduce go to https://test.visualize.admin.ch/en/browse/theme/https%3A%2F%2Fregister.ld.admin.ch%2Fopendataswiss%2Fcategory%2Fadministration?dataSource=Prod and select the first dataset.
I also fixed a smaller issue with search filters being cleared when going to dataset preview, this bug looked like in the video below; now the filters shouldn't be cleared anymore.
filters.mov