Merge pull request #1363 from visualize-admin/fix/non-optional-accessor

fix: Non-optional accessor
visualize-admin · Feb 23, 2024 · 9572d37 · 9572d37
2 parents f3b037b + 05f187c
commit 9572d37
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,12 +7,17 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 You can also check the [release page](https://github.com/visualize-admin/visualization-tool/releases)
 
-# [3.26.1] - 2023-12-22
+## Unreleased
+
+- Fixes
+  - The application no longer breaks in specific cases when filters were re-loaded
+
+# [3.26.1] - 2024-02-23
 
 - Fixes
   - Ability to copy/edit previous charts
 
-# [3.26.0] - 2023-12-21
+# [3.26.0] - 2024-02-20
 
 - Features
   - Layout step is now available without using a flag

diff --git a/app/configurator/components/field.tsx b/app/configurator/components/field.tsx
@@ -243,7 +243,9 @@ export const DataFilterSelect = ({
 
   const canUseMostRecentValue = isTemporalOrdinalDimension(dimension);
   const usesMostRecentValue = isDynamicMaxValue(fieldProps.value);
-  const maxValue = sortedValues[sortedValues.length - 1].value;
+  // Dimension values can be empty just before a filter is reloaded through
+  // ensurePossibleFilters
+  const maxValue = sortedValues[sortedValues.length - 1]?.value;
 
   return (
     <Select