Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webgl): Fix webglAdapter.attach() #2299

Merged
merged 1 commit into from
Dec 10, 2024
Merged

fix(webgl): Fix webglAdapter.attach() #2299

merged 1 commit into from
Dec 10, 2024

Conversation

ibgreen
Copy link
Collaborator

@ibgreen ibgreen commented Dec 9, 2024

For #2295

Background

Change List

  • Looks like the code path to attach to existing context had been lost during succession of refactors.
  • Also added CanvasContext creation and autoResize prevention.

@Pessimistress
Copy link
Collaborator

Should this apply to 9.1-release as well? (Instead of #2297)

@ibgreen
Copy link
Collaborator Author

ibgreen commented Dec 10, 2024

Should this apply to 9.1-release as well? (Instead of #2297)

Only if we see a need, I prefer to make minimal changes on the non-master branches. These parts of the code have been changing so there is a risk of having to debug twice or bring in more changes to 9.1.

Also the delta between master and 9.1 is bigger now after @felixpalmer reverted 9.1. changes to get luma 9.1 working in deck.gl test suite.

@ibgreen ibgreen merged commit b84bfbc into master Dec 10, 2024
2 checks passed
@ibgreen ibgreen deleted the ib/fix-gl2 branch December 10, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants