Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CARTO: Support gzip compression in RasterLayer #9352

Merged
merged 9 commits into from
Jan 15, 2025
Merged

CARTO: Support gzip compression in RasterLayer #9352

merged 9 commits into from
Jan 15, 2025

Conversation

felixpalmer
Copy link
Collaborator

Background

For more efficient storage of sparse data, we would like to support gzip directly on the payload

Change List

  • Read raster_metadata to check for compression field
  • Decompress using GZipCompression when compressed
  • Improved tests

@coveralls
Copy link

coveralls commented Jan 14, 2025 •
edited
Loading

Coverage Status

coverage: 91.676% (+0.004%) from 91.672%
when pulling df83353 on felix/raster-gzip
into 01d205b on master.

donmccurdy
donmccurdy approved these changes Jan 14, 2025
View reviewed changes
Copy link
Collaborator

@donmccurdy donmccurdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and demo is working well on local tests!

modules/carto/src/layers/schema/carto-raster-tile-loader.ts Outdated Show resolved Hide resolved
@felixpalmer felixpalmer merged commit 1dab786 into master Jan 15, 2025
4 checks passed
@felixpalmer felixpalmer deleted the felix/raster-gzip branch January 15, 2025 13:29
felixpalmer added a commit that referenced this pull request Jan 15, 2025
@felixpalmer
CARTO: Support gzip compression in RasterLayer (#9352)
9f44a6c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donmccurdy donmccurdy donmccurdy approved these changes

@srtena srtena Awaiting requested review from srtena

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@felixpalmer @coveralls @donmccurdy