feat(fc-pallet-pass): handle provisioning of system accounts for session keys #16
pandres95lint-pr.yml
on: pull_request_target
Validate PR title for conventional commit compliance
6s
Annotations
9 warnings
|
using `map_err` over `inspect_err`:
pallets/referenda-tracks/src/lib.rs#L93
warning: using `map_err` over `inspect_err`
--> pallets/referenda-tracks/src/lib.rs:93:15
|
93 | #[pallet::pallet]
| ^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_inspect
= note: `#[warn(clippy::manual_inspect)]` on by default
help: try
|
93 - #[pallet::pallet]
93 + #[pallet::&inspect_err]
|
|
|
using `map_err` over `inspect_err`:
pallets/pass/src/lib.rs#L83
warning: using `map_err` over `inspect_err`
--> pallets/pass/src/lib.rs:83:15
|
83 | #[pallet::pallet]
| ^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_inspect
= note: `#[warn(clippy::manual_inspect)]` on by default
help: try
|
83 - #[pallet::pallet]
83 + #[pallet::&inspect_err]
|
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
pallets/pass/src/extension.rs#L198
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> pallets/pass/src/extension.rs:198:27
|
198 | .pre_dispatch(&who, call, info, len)
| ^^^^ help: change this to: `who`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
redundant closure:
pallets/pass/src/extension.rs#L199
warning: redundant closure
--> pallets/pass/src/extension.rs:199:18
|
199 | .map(|pre| Some(pre))
| ^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `Some`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
= note: `#[warn(clippy::redundant_closure)]` on by default
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
pallets/pass/src/extension.rs#L183
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> pallets/pass/src/extension.rs:183:25
|
183 | self.0.validate(&who, call, info, len)
| ^^^^ help: change this to: `who`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
|
using `clone` on type `bool` which implements the `Copy` trait:
traits/authn/src/util.rs#L181
warning: using `clone` on type `bool` which implements the `Copy` trait
--> traits/authn/src/util.rs:181:18
|
181 | Self(self.0.clone(), PhantomData)
| ^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.0`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
|
|
using `clone` on type `bool` which implements the `Copy` trait:
traits/authn/src/util.rs#L169
warning: using `clone` on type `bool` which implements the `Copy` trait
--> traits/authn/src/util.rs:169:18
|
169 | Self(self.0.clone(), PhantomData)
| ^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.0`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
= note: `#[warn(clippy::clone_on_copy)]` on by default
|
|
using `map_err` over `inspect_err`:
pallets/template/src/lib.rs#L34
warning: using `map_err` over `inspect_err`
--> pallets/template/src/lib.rs:34:15
|
34 | #[pallet::pallet]
| ^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_inspect
= note: `#[warn(clippy::manual_inspect)]` on by default
help: try
|
34 - #[pallet::pallet]
34 + #[pallet::&inspect_err]
|
|
|
using `map_err` over `inspect_err`:
pallets/gas-transaction-payment/src/lib.rs#L32
warning: using `map_err` over `inspect_err`
--> pallets/gas-transaction-payment/src/lib.rs:32:15
|
32 | #[pallet::pallet]
| ^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_inspect
= note: `#[warn(clippy::manual_inspect)]` on by default
help: try
|
32 - #[pallet::pallet]
32 + #[pallet::&inspect_err]
|
|