Skip to content

Pallet Pass

Pallet Pass #5

Triggered via pull request September 27, 2024 05:54
@pandres95pandres95
synchronize #22
pallet-pass
Status Failure
Total duration 1m 45s
Artifacts

ci.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

5 errors and 17 warnings
no variant or associated item named `Success` found for enum `pallet::Event` in the current scope: pallets/pass/src/benchmarking.rs#L23
error[E0599]: no variant or associated item named `Success` found for enum `pallet::Event` in the current scope --> pallets/pass/src/benchmarking.rs:23:39 | 23 | assert_last_event::<T>(Event::Success.into()); | ^^^^^^^ variant or associated item not found in `Event<_, _>` | ::: pallets/pass/src/lib.rs:84:5 | 84 | pub enum Event<T: Config<I>, I: 'static = ()> { | --------------------------------------------- variant or associated item `Success` not found for this enum
function takes 2 generic arguments but 1 generic argument was supplied: pallets/pass/src/benchmarking.rs#L23
error[E0107]: function takes 2 generic arguments but 1 generic argument was supplied --> pallets/pass/src/benchmarking.rs:23:9 | 23 | assert_last_event::<T>(Event::Success.into()); | ^^^^^^^^^^^^^^^^^ - supplied 1 generic argument | | | expected 2 generic arguments | note: function defined here, with 2 generic parameters: `T`, `I` --> pallets/pass/src/benchmarking.rs:7:4 | 7 | fn assert_last_event<T: Config<I>, I: 'static>(generic_event: <T as Config<I>>::RuntimeEvent) { | ^^^^^^^^^^^^^^^^^ - - help: add missing generic argument | 23 | assert_last_event::<T, I>(Event::Success.into()); | +++
check
Process completed with exit code 101.
clippy
Clippy had exited with the 101 exit code
test
Process completed with exit code 101.
using `map_err` over `inspect_err`: pallets/template/src/lib.rs#L34
warning: using `map_err` over `inspect_err` --> pallets/template/src/lib.rs:34:15 | 34 | #[pallet::pallet] | ^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_inspect = note: `#[warn(clippy::manual_inspect)]` on by default help: try | 34 - #[pallet::pallet] 34 + #[pallet::&inspect_err] |
`self.0.saturating_sub(n.get())` is never smaller than `Self::MIN.0` and has therefore no effect: traits/memberships/src/lib.rs#L98
warning: `self.0.saturating_sub(n.get())` is never smaller than `Self::MIN.0` and has therefore no effect --> traits/memberships/src/lib.rs:98:14 | 98 | Self(self.0.saturating_sub(n.get()).max(Self::MIN.0)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.0.saturating_sub(n.get())` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_min_or_max = note: `#[warn(clippy::unnecessary_min_or_max)]` on by default
duplicated attribute: pallets/template/src/benchmarking.rs#L1
warning: duplicated attribute --> pallets/template/src/benchmarking.rs:1:8 | 1 | #![cfg(feature = "runtime-benchmarks")] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | note: first defined here --> pallets/template/src/lib.rs:10:7 | 10 | #[cfg(feature = "runtime-benchmarks")] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove this attribute --> pallets/template/src/benchmarking.rs:1:8 | 1 | #![cfg(feature = "runtime-benchmarks")] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duplicated_attributes = note: `#[warn(clippy::duplicated_attributes)]` on by default
using `map_err` over `inspect_err`: pallets/referenda-tracks/src/lib.rs#L93
warning: using `map_err` over `inspect_err` --> pallets/referenda-tracks/src/lib.rs:93:15 | 93 | #[pallet::pallet] | ^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_inspect = note: `#[warn(clippy::manual_inspect)]` on by default help: try | 93 - #[pallet::pallet] 93 + #[pallet::&inspect_err] |
empty doc comment: pallets/referenda-tracks/src/lib.rs#L86
warning: empty doc comment --> pallets/referenda-tracks/src/lib.rs:86:9 | 86 | /// | ^^^ | = help: consider removing or filling it = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_docs = note: `#[warn(clippy::empty_docs)]` on by default
useless conversion to the same type: `()`: pallets/referenda-tracks/src/impls.rs#L96
warning: useless conversion to the same type: `()` --> pallets/referenda-tracks/src/impls.rs:96:12 | 96 | Ok(().into()) | ^^^^^^^^^ help: consider removing `.into()`: `()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `#[warn(clippy::useless_conversion)]` on by default
passing a unit value to a function: pallets/referenda-tracks/src/impls.rs#L96
warning: passing a unit value to a function --> pallets/referenda-tracks/src/impls.rs:96:9 | 96 | Ok(().into()) | ^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg = note: `#[warn(clippy::unit_arg)]` on by default help: move the expression in front of the call and replace it with the unit literal `()` | 96 ~ ().into(); 97 + Ok(()) |
using `map_err` over `inspect_err`: pallets/gas-transaction-payment/src/lib.rs#L32
warning: using `map_err` over `inspect_err` --> pallets/gas-transaction-payment/src/lib.rs:32:15 | 32 | #[pallet::pallet] | ^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_inspect = note: `#[warn(clippy::manual_inspect)]` on by default help: try | 32 - #[pallet::pallet] 32 + #[pallet::&inspect_err] |
binary comparison to literal `Option::None`: pallets/referenda-tracks/src/impls.rs#L41
warning: binary comparison to literal `Option::None` --> pallets/referenda-tracks/src/impls.rs:41:13 | 41 | Tracks::<T, I>::get(id) == None, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `Tracks::<T, I>::get(id).is_none()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none = note: `#[warn(clippy::partialeq_to_none)]` on by default
using `clone` on type `<T as Config<I>>::TrackId` which implements the `Copy` trait: pallets/referenda-tracks/src/benchmarking.rs#L86
warning: using `clone` on type `<T as Config<I>>::TrackId` which implements the `Copy` trait --> pallets/referenda-tracks/src/benchmarking.rs:86:57 | 86 | OriginToTrackId::<T, I>::insert(origin.clone(), id.clone()); | ^^^^^^^^^^ help: try dereferencing it: `*id` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
using `clone` on type `<T as Config<I>>::TrackId` which implements the `Copy` trait: pallets/referenda-tracks/src/benchmarking.rs#L85
warning: using `clone` on type `<T as Config<I>>::TrackId` which implements the `Copy` trait --> pallets/referenda-tracks/src/benchmarking.rs:85:32 | 85 | Tracks::<T, I>::insert(id.clone(), track.clone()); | ^^^^^^^^^^ help: try dereferencing it: `*id` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy = note: `#[warn(clippy::clone_on_copy)]` on by default
using `clone` on type `DispatchInfo` which implements the `Copy` trait: pallets/gas-transaction-payment/src/extensions.rs#L120
warning: using `clone` on type `DispatchInfo` which implements the `Copy` trait --> pallets/gas-transaction-payment/src/extensions.rs:120:22 | 120 | &info.clone().into(), | ^^^^^^^^^^^^ help: try dereferencing it: `(*info)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy = note: `#[warn(clippy::clone_on_copy)]` on by default
useless conversion to the same type: `frame_support::dispatch::DispatchInfo`: pallets/gas-transaction-payment/src/extensions.rs#L120
warning: useless conversion to the same type: `frame_support::dispatch::DispatchInfo` --> pallets/gas-transaction-payment/src/extensions.rs:120:22 | 120 | &info.clone().into(), | ^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `info.clone()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `#[warn(clippy::useless_conversion)]` on by default
duplicated attribute: pallets/referenda-tracks/src/benchmarking.rs#L20
warning: duplicated attribute --> pallets/referenda-tracks/src/benchmarking.rs:20:8 | 20 | #![cfg(feature = "runtime-benchmarks")] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | note: first defined here --> pallets/referenda-tracks/src/lib.rs:37:7 | 37 | #[cfg(feature = "runtime-benchmarks")] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove this attribute --> pallets/referenda-tracks/src/benchmarking.rs:20:8 | 20 | #![cfg(feature = "runtime-benchmarks")] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duplicated_attributes = note: `#[warn(clippy::duplicated_attributes)]` on by default
redundant pattern matching, consider using `is_some()`: pallets/gas-transaction-payment/src/extensions.rs#L102
warning: redundant pattern matching, consider using `is_some()` --> pallets/gas-transaction-payment/src/extensions.rs:102:16 | 102 | if let Some(_) = T::GasBurner::check_available_gas(who, &info.weight) { | -------^^^^^^^------------------------------------------------------- help: try: `if T::GasBurner::check_available_gas(who, &info.weight).is_some()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching = note: `#[warn(clippy::redundant_pattern_matching)]` on by default
clippy
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
clippy
The following actions use a deprecated Node.js version and will be forced to run on node20: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/